Fix: changed php_eos_datastructures_check_value to actually compare a…#3
Open
mhertsch wants to merge 1 commit intoeosforphp:masterfrom
Open
Fix: changed php_eos_datastructures_check_value to actually compare a…#3mhertsch wants to merge 1 commit intoeosforphp:masterfrom
mhertsch wants to merge 1 commit intoeosforphp:masterfrom
Conversation
… long against value instead of a ptr which always failed
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… long against value instead of a ptr which always failed
Hi @auroraeosrose,
please have a look at this pull request, that as far as I can see, fixed the issues with the check value function, that always failed with an error when used for example in pecl-cairo:
TypeError: Value 1 provided is not a const in enum Cairo\Antialias
Cheers,
Michael